-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preserve ACL/Permissions while uploading file over datalake #1571
Open
vibhansa-msft
wants to merge
17
commits into
main
Choose a base branch
from
vibhansa/adls_aclfix
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+171
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vibhansa-msft
requested review from
souravgupta-msft,
ashruti-msft,
syeleti-msft and
jainakanksha-msft
as code owners
November 18, 2024 09:15
vibhansa-msft
changed the title
Vibhansa/adls aclfix
Preserve ACL/Permissions while uploading file over datalake
Nov 18, 2024
souravgupta-msft
approved these changes
Nov 19, 2024
jainakanksha-msft
approved these changes
Nov 20, 2024
syeleti-msft
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ What
When files are uploaded to datalake storage, Permissions and ACL set on the file previously are lost.
🤔 Why
Upload APIs do not set ACLs back. We need to make additional REST call to get the access control list and set it back after the upload.
👩🔬 How to validate if applicable
Create a file on datalake, set the permissions from portal and then edit the file from blobfuse. ACLs/Permissions will be lost once file is saved from blobfuse end.
🔖 Related links
NA