Move version checks from public container to static website #1550
+67
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vibhansa-msft
requested review from
souravgupta-msft,
ashruti-msft,
syeleti-msft and
jainakanksha-msft
as code owners
|
Current changeset is getting an index.xml file from the website and expects it will have latest version written under <latest> tag in that xml file. |
vibhansa-msft
changed the title
souravgupta-msft
approved these changes
Nov 20, 2024
ashruti-msft
approved these changes
Nov 21, 2024
souravgupta-msft
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ What
Version check is done on a public container with anonymous access, but due to security issues the public access will be terminated soon.
Now onwards the version check with work through a static website hosted on same storage account,
🤔 Why
Security vulnerability restricting anonymous access.
👩🔬 How to validate if applicable
Check the URI used to retrieve the latest version
🔖 Related links
NA