Vibhansa/truncate update #1517
Open
Vibhansa/truncate update #1517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Preserve block on flush and delete them on close instead.
* Adding proxy from environment fix
* Enabling random write
* adding direct_io data validation test with block cache
* New data test pipeline added
* return error when download fails during overwriting a block
vibhansa-msft
requested review from
souravgupta-msft,
ashruti-msft and
syeleti-msft
as code owners
| } | ||
| return data, err | ||
|
|
||
| return bb.createSparseFile(name, newSize, blockSize, blkList, idLen) |
There was a problem hiding this comment.
If file size is not aligning with the block size and truncate is used to expand the size, this will lead to irregular blocksizes in the block list.
Eg: lets say blocksize = 4M
file size = 5M (i.e., 2blocks) block1 = 4M, block2 = 1M
Call for truncate(10M)
I suppose the logic in this PR will make the block list look like this after truncate operation:
block1 = 4M, block2 = 1M, block3 = 4M, block4 = 1M.
Although this looks correct but the subsequent operations in block cache cannot utilize this sort of blocklist.
Please correct me if I am wrong
| return data, err | ||
| } | ||
|
|
||
| func (bb *BlockBlob) createSparseFile(name string, size int64, blockSize int64, blkList []string, idLen int64) error { |
There was a problem hiding this comment.
It is better to have 2 functions originating from truncate function which are
- Expand
- Shrink
This will make the code more readable imo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.