Adding MSI Login Example #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zezha-msft
reviewed
Dec 23, 2020
azblob/zt_examples_test.go
Outdated
| log.Fatal(err) | ||
| } | ||
|
|
||
| // Refresh obtains a fresh token for the Service Principal. |
There was a problem hiding this comment.
typo: Service Principal
azblob/zt_examples_test.go
Outdated
|
|
||
| tc := NewTokenCredential(spt.Token().AccessToken, func(tc TokenCredential) time.Duration { | ||
| _ = spt.Refresh() | ||
| return time.Until(spt.Token().Expires()) |
There was a problem hiding this comment.
Perhaps it's best to deduct a slight buffer from the expiration so that the token credential is always valid.
zezha-msft
reviewed
Dec 23, 2020
azblob/zt_examples_test.go
Outdated
| // result := &adal.Token{} | ||
| // if len(b) > 0 { | ||
| // b = ByteSliceExtension{ByteSlice: b}.RemoveBOM() | ||
| // if err := json.Unmarshal(b, result); err != nil { |
There was a problem hiding this comment.
This commented code should be removed, right?
adreed-msft
approved these changes
Mar 23, 2021
| var err error | ||
|
|
||
| // both can be empty, systemAssignedMSI scenario | ||
| if applicationID == "" && identityResourceID == "" { |
There was a problem hiding this comment.
code cleanliness: else ifs would be preferable here
mohsha-msft
added a commit
that referenced
this pull request
Mar 25, 2021
* Adding MSI Login Example (#241) * Added MSI login example * Minor edits Co-authored-by: zezha-msft <[email protected]> * Reverting changes to GetTags/SetTags & BlobPropertiesInternal Co-authored-by: Mohit Sharma <[email protected]> Co-authored-by: zezha-msft <[email protected]>
mohsha-msft
added a commit
that referenced
this pull request
Apr 7, 2021
* Provide Knob For Syslog * Reverting changes to GetTags/SetTags & BlobPropertiesInternal (#269) * Adding MSI Login Example (#241) * Added MSI login example * Minor edits Co-authored-by: zezha-msft <[email protected]> * Reverting changes to GetTags/SetTags & BlobPropertiesInternal Co-authored-by: Mohit Sharma <[email protected]> Co-authored-by: zezha-msft <[email protected]> Co-authored-by: siminsavani-msft <[email protected]> Co-authored-by: zezha-msft <[email protected]>
siminsavani-msft
added a commit
that referenced
this pull request
Jul 2, 2021
* Removed requestId, Timeout, versionId, snapshot from the function signature of GetTags() and SetTags() (#252) * Changed the function signature of getTags and setTags * Minor Adjustment * Review - 1 * Adding Support for PutBlobFromUrl (#251) * Regenerate SDK * Regenerate SDK with proper version * Adding support for PutBlobFromURL * Correcting regen code and handling other errors * Resolving comments on PR * Correcting SetTags method * Updating tests with GetTags and SetTags * Remove swagger/Go_BlobStorage/code-model-v1 * Checks value of metadata & reorganized tests Co-authored-by: Adele Reed <[email protected]> * Keep compatibility with Go 1.13.14. (#264) * - Keep compliance with Golang 1.13.14. http.Header has no method Values on older go versions. * Do not return error when client request id is missing * Adding MSI Login Example (#241) * Added MSI login example * Minor edits Co-authored-by: zezha-msft <[email protected]> * Offer Knob to Disable Syslog | Default logging to syslog enabled (#268) * Provide Knob For Syslog * Reverting changes to GetTags/SetTags & BlobPropertiesInternal (#269) * Adding MSI Login Example (#241) * Added MSI login example * Minor edits Co-authored-by: zezha-msft <[email protected]> * Reverting changes to GetTags/SetTags & BlobPropertiesInternal Co-authored-by: Mohit Sharma <[email protected]> Co-authored-by: zezha-msft <[email protected]> Co-authored-by: siminsavani-msft <[email protected]> Co-authored-by: zezha-msft <[email protected]> * Update go dependencies * Resolving Concurrency Issues (#275) * Resolving concurrency issues * Fixing concurrency test * Minor changes * Incremented version and added to changelog * Updated version to 0.14 Co-authored-by: Mohit Sharma <[email protected]> Co-authored-by: Adele Reed <[email protected]> Co-authored-by: Sreejith Kesavan <[email protected]> Co-authored-by: zezha-msft <[email protected]> Co-authored-by: Yang Peng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.