Fix for File Share Limit Reached Error #2892
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wonwuakpa-msft
requested review from
gapra-msft,
adreed-msft,
dphulkar-msft,
vibhansa-msft,
seanmcc-msft,
souravgupta-msft and
tanyasethi-msft
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added nil and closure checks to ensure there's no
panicfrom closing channels. Added a description for theShareSizeLimitReachederror to guide users on how to handle the errorFeature / Bug Fix: (Brief description of the feature or issue being addressed)
User reported this AzCopy behavior when uploading data to a file share that exceeds the quota (i.e uploading 4GB to a 1GB file share). When the quota is hit, the ongoing job is stopped and the already uploaded files are not deleted. AzCopy team concluded this is not a bug. There is a high chance of unnecessary failed API calls after the
ShareSizeLimitReachederror is hit. Thus, the current behavior of stopping the job is valid.Related Links:
Issues
Expected AzCopy Behavior When Exceeding Quotas
Type of Change
How Has This Been Tested?
AzCopy randomly uploads files to the file share until the quota is hit. Wrote a script to validate that these uploaded files are non-empty. If empty files are uploaded, they are correctly deleted in the cleanup handler in the codebase.
Thank you for your contribution to AzCopy!