Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added totalBytesSkipped and using this in percentage complete calculation #2856

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

StefanNestorovski
Copy link

Description

Added a new object called "TotalBytesSkipped" which stores the amount of data skipped during file copying. This TotalBytesSkipped is added to all the summary messages as well as used in the "Percentage complete" calculation.

Type of Change

  • [x ] Bug fix
  • New feature
  • Documentation update required
  • Code quality improvement
  • Other (describe):

How Has This Been Tested?

Tested on windows 11 only:
Ran AzCopy with "--overwrite=ifSourceNewer" on a folder containing some new files and some files already in blob, output % was correctly measured with the skips included.
Ran AzCopy with "--overwrite=ifSourceNewer" on a folder where all the data was already in the blob and all data was skipped and output was still displaying 100% done.

Thank you for your contribution to AzCopy!

@StefanNestorovski
Copy link
Author

@StefanNestorovski please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@StefanNestorovski
Copy link
Author

@StefanNestorovski please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree [company="GeologicAI"]

@StefanNestorovski
Copy link
Author

@microsoft-github-policy-service agree company="your company"

@microsoft-github-policy-service agree company="GeologicAI"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant