-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix symlink #1798
Merged
Merged
Fix symlink #1798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nakulkar-msft
suggested changes
Jun 1, 2022
Strikerzee
changed the title
Introduce changes for job progress status and fix symlink
Fix symlink
Jun 6, 2022
Changes for jobProgress status. - If job marked complete, drain all the messages from jobStatus channel. Fix the symlink. - Calling filepath.evalsymlinks in case of linux. - Explicit checking "." (current directory) for symlink. Remove snippet of code not relevant to the cherry-picked commits.
…mmit." This reverts commit 94bf95f.
- Calling filepath.evalsymlinks in case of linux. - Explicit checking "." (current directory) for symlink.
Strikerzee
force-pushed
the
personal/arnav/job-progress-fix-symlink
branch
from
June 7, 2022 13:07
c820eb8
to
ec04d04
Compare
mohsha-msft
approved these changes
Jun 9, 2022
nakulkar-msft
approved these changes
Jun 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the symlink. (Cherry-picked from personal/nitin/xdatamove)
Remove snippet of code not relevant to the cherry-picked commits.