Fixing a rare case of AuthorizationFailedException #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the exact time the client is creating a link. If the connection is closed by service after CBS token is sent, link open operaiton was failing with AuthorizsationFailed exception.
nemakam
reviewed
Jun 26, 2019
| // Connection closed after sending CBS token. Happens only in the rare case of azure service bus closing idle connection, just right after sending | ||
| // CBS token but before opening a link. | ||
| TRACE_LOGGER.warn("Idle connection closed by service just after sending CBS token. Very rare case. Will retry."); | ||
| ServiceBusException exception = new ServiceBusException(true, "Idle connection closed by service just after sending CBS token. Please retry."); |
There was a problem hiding this comment.
just after sending CBS token [](start = 100, length = 28)
Wonder if this is too much of details mentioning about CBS.
nemakam
reviewed
Jun 26, 2019
| // Connection closed after sending CBS token. Happens only in the rare case of azure service bus closing idle connection, just right after sending | ||
| // CBS token but before opening a link. | ||
| TRACE_LOGGER.warn("Idle connection closed by service just after sending CBS token. Very rare case. Will retry."); | ||
| ServiceBusException exception = new ServiceBusException(true, "Idle connection closed by service just after sending CBS token. Please retry."); |
There was a problem hiding this comment.
ServiceBusException [](start = 39, length = 19)
Should this be SBCommunicationException?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some customers use a cached QueueClient or MessageSender to send messages. If a client or sender remains idle for 15 minutes, the service closes the connection as idle connection. In some rare cases, the service closes the connection just when the client is trying to open a link on the same connection. If the connection is closed by service after CBS token is sent, link open operation was failing with AuthorizationFailed exception.