Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use metadata service to grab JWT token #298

Merged
merged 1 commit into from
Nov 30, 2018
Merged

Conversation

sjyang18
Copy link

Description

This is a patch to fix the issue I reported in (#297). Reference document is https://docs.microsoft.com/en-us/azure/active-directory/managed-identities-azure-resources/how-to-use-vm-token.

This checklist is used to make sure that common guidelines for a pull request are followed.

  • I have read the contribution guidelines.
  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR.
  • The pull request does not introduce breaking changes (unless a major version change occurs in the assembly and module).
  • If applicable, the public code is properly documented.
  • Pull request includes test coverage for the included changes.
  • The code builds without any errors.

@warrenzhu25
Copy link

I want to try MSI feature, but I got com.microsoft.azure.servicebus.primitives.ServiceBusException: Error{condition=amqp:connection:framing-error, description='connection aborted', info=null}. I used 1.2.8. Want to confirm which version should I use? Is there some log I can search for to determine whether MSI took effect?

@sjyang18
Copy link
Author

Definitely, 1.2.8 does not include my patch and I verified that.
My patch was merged into dev, and eventually in the master branch, but it doesn't seem to be included in the latest release.

https://github.com/Azure/azure-service-bus-java/blob/master/azure-servicebus/src/main/java/com/microsoft/azure/servicebus/security/ManagedServiceIdentityTokenProvider.java

I will contact the team and let them know.
Meanwhile, you may checkout and build the master branch locally, and try out.
Or, you may checkout my workaround (https://github.com/sjyang18/ServiceBusWithManagedIdentity) with 1.2.8.

yvgopal pushed a commit to yvgopal/azure-service-bus-java-1 that referenced this pull request Jun 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants