Create-ApiReview honors PackageProperty files
#9412
Conversation
…re present in the artifact list
|
The following pipelines have been queued for testing: |
| $result = ProcessPackage -packageName $artifact.name | ||
| $responses[$artifact.name] = $result | ||
| $propFiles = Get-ChildItem -Path $ConfigFileDir -Recurse -Filter "*.json" | ||
| $artifactPackages = $ArtifactList | ForEach-Object { $_["name"] } |
There was a problem hiding this comment.
Shouldn't this be $_.name or is this a hashtable object?
There was a problem hiding this comment.
It's a hashtable object, both will actually work here.
| $artifact = Get-Content $propFile.FullName -Raw | ConvertFrom-Json -AsHashtable | ||
| if ($artifactPackages -contains $propFile.Name.Replace(".json", "")) | ||
| { | ||
| Write-Host "Processing $($artifact.ArtifactName)" |
There was a problem hiding this comment.
Isn't the artifact name the same as the file or are their cases where they are different? If they are the same, we probably can avoid reading the json file. If they aren't the same we probably should use the artifactname in your condition instead of the file name.
There was a problem hiding this comment.
$pkgInfo.ArtifactName == <package-json-file-name> everywhere I'm aware of. I'll add comments for clarity and double check, but I'm fairly certain.
See title.
@praveenkuttappan Detect-Api-Changes explicitly walks the prop files to begin with. So we're already covered there.
Pardon the other spacing updates. My
powershellvscode extension is aggressive 👍