Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable InitializeCIArtifacts on Non-CI Builds #9330

Merged
merged 3 commits into from
Nov 5, 2024
Merged

Disable InitializeCIArtifacts on Non-CI Builds #9330

merged 3 commits into from
Nov 5, 2024

Conversation

scbedd
Copy link
Member

@scbedd scbedd commented Nov 5, 2024

Until we fix up the loop for usage of yq vs ConvertFrom-Yaml within Package-Properties.ps1.

@scbedd scbedd self-assigned this Nov 5, 2024
@scbedd scbedd requested a review from a team as a code owner November 5, 2024 18:32
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

benbp
benbp approved these changes Nov 5, 2024
View reviewed changes
Copy link
Member

@benbp benbp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 with some suggestions

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

This was referenced Nov 5, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@scbedd
Copy link
Member Author

scbedd commented Nov 5, 2024

When I squash merged a couple of these PRS, the cleanup branch was checked.

The sync pr creation is failing because we are targeting a branch that doesn't exist.

I'm going to check enforcer override and just merge this. Won't mess up the manual merge in the future.

@scbedd
Copy link
Member Author

scbedd commented Nov 5, 2024

/check-enforcer override

@scbedd scbedd merged commit 8fd2675 into main Nov 5, 2024
11 of 13 checks passed
@scbedd scbedd deleted the save-package-properties branch November 5, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benbp benbp benbp approved these changes

Assignees

@scbedd scbedd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scbedd @azure-sdk @benbp