Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use $GITHUB_EVENT_PATH variable instead of inline file writing #9134

Merged
merged 2 commits into from
Oct 15, 2024

Conversation

benbp
Copy link
Member

@benbp benbp commented Oct 10, 2024

Reduce github event processor logging

FYI @JimSuplizio I didn't know until now that you can grab the webhook payload from disk (thanks to @hallipr). This saves us a lot of log storage space, as before I was putting the whole payload inline to the bash command (to work around env var max size issues).

@benbp benbp added the Central-EngSys This issue is owned by the Engineering System team. label Oct 10, 2024
@benbp benbp self-assigned this Oct 10, 2024
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@benbp benbp force-pushed the benbp/gh-event-logging branch from fb9ab78 to 692203f Compare October 10, 2024 21:57
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

Copy link
Member

@JimSuplizio JimSuplizio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@benbp this is great, I didn't know this was a thing either. @hallipr, great find!

@benbp benbp enabled auto-merge (squash) October 15, 2024 21:05
azure-sdk added a commit to Azure/azure-sdk-for-js that referenced this pull request Oct 15, 2024
…1412)

Sync .github/workflows directory with azure-sdk-tools for PR
Azure/azure-sdk-tools#9134 See [eng/common
workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow)

---------

Co-authored-by: Ben Broderick Phillips <[email protected]>
@benbp benbp merged commit 7a9ff94 into Azure:main Oct 15, 2024
8 checks passed
${{ toJson(github.event) }}
EOF
github-event-processor ${{ github.event_name }} payload.json CloseAddressedIssues
github-event-processor ${{ github.event_name }} ${{ github.event_path }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we all missed the fact you deleted CloseAddressedIssues which is causing failures like https://github.com/Azure/azure-sdk/actions/runs/11358965282/job/31594328835

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Central-EngSys This issue is owned by the Engineering System team.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants