Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use equality function check for persist oidc token step #9113

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

benbp
Copy link
Member

@benbp benbp commented Oct 8, 2024

Use equality function check for persist oidc token step

This is breaking the conditional evaluation of ${{ if parameters.PersistOidcToken }} because it is getting stringified.

@benbp benbp requested a review from a team as a code owner October 8, 2024 21:54
@benbp benbp added the Central-EngSys This issue is owned by the Engineering System team. label Oct 8, 2024
@benbp benbp self-assigned this Oct 8, 2024
@benbp benbp requested review from weshaggard and scbedd October 8, 2024 21:54
@benbp benbp force-pushed the benbp/fix-deploy-types branch from c3b4b26 to e10ee6c Compare October 8, 2024 22:04
@benbp benbp changed the title Use full typing schema for deploy-test-resources variable declaration Use equality function check for persist oidc token step Oct 8, 2024
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

scbedd pushed a commit to Azure/azure-sdk-for-js that referenced this pull request Oct 8, 2024
@scbedd scbedd merged commit 9db756e into Azure:main Oct 8, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Central-EngSys This issue is owned by the Engineering System team.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants