Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Persist oidc env vars in deploy template #9099

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Persist oidc env vars in deploy template #9099

merged 1 commit into from
Oct 8, 2024

Conversation

benbp
Copy link
Member

@benbp benbp commented Oct 4, 2024 •
edited
Loading

@benbp benbp requested a review from a team as a code owner October 4, 2024 23:00
@benbp benbp added the Central-EngSys This issue is owned by the Engineering System team. label Oct 4, 2024
@benbp benbp self-assigned this Oct 4, 2024
@benbp benbp requested a review from weshaggard October 4, 2024 23:00
@benbp benbp mentioned this pull request Oct 4, 2024
Merged
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@benbp benbp mentioned this pull request Oct 4, 2024
Merged
6 tasks
weshaggard
weshaggard approved these changes Oct 7, 2024
View reviewed changes
Copy link
Member

@weshaggard weshaggard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should scope to just OIDC token if possible.

@benbp benbp force-pushed the benbp/pre-steps-multi-cloud-test branch from 9875957 to 1e508d7 Compare October 8, 2024 16:58
This was referenced Oct 8, 2024
Open
Closed
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@benbp benbp mentioned this pull request Oct 8, 2024
Open
This was referenced Oct 8, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
azure-sdk added a commit to Azure/azure-sdk-for-js that referenced this pull request Oct 8, 2024
@azure-sdk @benbp
Sync eng/common directory with azure-sdk-tools for PR 9099 (#31336)
4fc29fe 
Sync eng/common directory with azure-sdk-tools for PR
Azure/azure-sdk-tools#9099 See [eng/common
workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow)

Co-authored-by: Ben Broderick Phillips <[email protected]>
@benbp benbp merged commit 49d6a08 into Azure:main Oct 8, 2024
8 checks passed
@benbp benbp deleted the benbp/pre-steps-multi-cloud-test branch October 8, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weshaggard weshaggard weshaggard approved these changes

Assignees

@benbp benbp

Labels
Central-EngSys This issue is owned by the Engineering System team.
Projects
Azure SDK EngSys 🚢🎉
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benbp @azure-sdk @weshaggard