-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removal of the devops release PAT #8388
Conversation
The following pipelines have been queued for testing: |
The following pipelines have been queued for testing: |
The following pipelines have been queued for testing: |
384d7a9
to
1577688
Compare
The following pipelines have been queued for testing: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good but as we talked lets wait until after releases finish after tues before merging. We should also make sure these don't break @praveenkuttappan's work.
a74b99c
to
83f3f2b
Compare
The following pipelines have been queued for testing: |
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#8388 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) --------- Co-authored-by: James Suplizio <[email protected]>
This PR won't be merged until Thursday 6/13 as to not interfere with releases.
These are the code changes to remove the devops release PAT. Use the AzureCLI task and get the token from azure. The other AZ commands that the scripts use should be fine with the azureSubscription.
The LoginToAzureDevops function in DevOps-WorkItem-Helpers.ps1 is no longer necessary. The scenario for using this is that we passed the PAT to the pipeline and the variable was being used to log into azure. Being that this now needs to be run in an environment that's already logged into azure this function is completely moot.
The validate packages and update work items steps are part of the Build for Java, JS and NET. For Python these steps are in Analyze.