Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of the devops release PAT #8388

Merged
merged 3 commits into from
Jun 13, 2024

Conversation

JimSuplizio
Copy link
Member

@JimSuplizio JimSuplizio commented Jun 6, 2024

This PR won't be merged until Thursday 6/13 as to not interfere with releases.

These are the code changes to remove the devops release PAT. Use the AzureCLI task and get the token from azure. The other AZ commands that the scripts use should be fine with the azureSubscription.

The LoginToAzureDevops function in DevOps-WorkItem-Helpers.ps1 is no longer necessary. The scenario for using this is that we passed the PAT to the pipeline and the variable was being used to log into azure. Being that this now needs to be run in an environment that's already logged into azure this function is completely moot.

The validate packages and update work items steps are part of the Build for Java, JS and NET. For Python these steps are in Analyze.

@JimSuplizio JimSuplizio self-assigned this Jun 6, 2024
@JimSuplizio JimSuplizio marked this pull request as ready for review June 6, 2024 21:35
@JimSuplizio JimSuplizio requested a review from a team as a code owner June 6, 2024 21:35
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@JimSuplizio JimSuplizio force-pushed the RemDevOpsRelWIPat branch 2 times, most recently from 384d7a9 to 1577688 Compare June 7, 2024 17:53
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

Copy link
Member

@weshaggard weshaggard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good but as we talked lets wait until after releases finish after tues before merging. We should also make sure these don't break @praveenkuttappan's work.

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

azure-sdk added a commit to Azure/azure-sdk-for-js that referenced this pull request Jun 13, 2024
@JimSuplizio JimSuplizio merged commit 085e415 into Azure:main Jun 13, 2024
16 checks passed
@JimSuplizio JimSuplizio deleted the RemDevOpsRelWIPat branch June 13, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants