Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge eng/ from main on assets push #8020

Merged
merged 13 commits into from
Apr 6, 2024
Merged

Merge eng/ from main on assets push #8020

merged 13 commits into from
Apr 6, 2024

Conversation

scbedd
Copy link
Member

@scbedd scbedd commented Apr 4, 2024

@weshaggard I'm extremely pleased with this little diff methodology. Let me know what you think.

  • Handle when the patch is empty (call out to git apply --check)
  • PR another change that fixes the tools build/livetests
  • Resolve integration issue on pure windows git discovered in integration tests. Why is a soft reset failing?
    • This was failing due to a case that should only really ever occur in our test cases, where we force a failed auth by setting an invalid GIT_TOKEN. This meant that we failed to retrieve remote main for the patch. The weird error we were seeing on CLI integration for windows, is that a soft reset with uncommitted changes resulted in a weird error state that git couldn't understand how to resolve automatically. (unable to retrieve promisor remote) By placing the soft reset behind the changes actually being committed, we totally sidestep the entire problem.

@scbedd scbedd self-assigned this Apr 4, 2024
@scbedd scbedd requested a review from mikeharder as a code owner April 4, 2024 00:01
@scbedd
Copy link
Member Author

scbedd commented Apr 5, 2024

/azp run tools - test-proxy - tests

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@scbedd scbedd merged commit bb98c07 into main Apr 6, 2024
31 checks passed
@scbedd scbedd deleted the feature/merge-main-on-push branch April 6, 2024 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants