Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A pshell update (7.4?) caused git show to stop working #7986

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

scbedd
Copy link
Member

@scbedd scbedd commented Apr 2, 2024

  • git show head:sdk\storage\Azure.Storage.Blob\assets.json no longer results in visible output.
    • The script grabs the tag from the left side of the merge, holds it constant, and merges the incoming branch tag into the assets. If we aren't able to properly utilize git show, we can't generate the left or right side of the assets.json, and end up setting the assets.json to empty.
  • git show head:sdk/storage/Azure.Storage.Blob/assets.json does still work, so amending the command

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

Copy link
Member

@JonathanCrd JonathanCrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

scbedd added a commit to Azure/azure-sdk-for-js that referenced this pull request Apr 2, 2024
@scbedd scbedd enabled auto-merge (squash) April 2, 2024 01:44
@scbedd scbedd merged commit 0999906 into Azure:main Apr 2, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants