Skip API review package name approval for management plane packages #7977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
praveenkuttappan
added
APIView
Central-EngSys
praveenkuttappan
requested review from
konrad-jamrozik,
weshaggard and
benbp
as code owners
|
The following pipelines have been queued for testing: |
This was referenced Mar 29, 2024
weshaggard
reviewed
Mar 29, 2024
weshaggard
reviewed
Mar 29, 2024
weshaggard
reviewed
Mar 29, 2024
| @@ -153,6 +153,13 @@ function Submit-APIReview($packageInfo, $packagePath) | |||
| } | |||
| } | |||
|
|
|||
| function IsApiviewStatusCheckRequired($packageInfo) | |||
There was a problem hiding this comment.
How do you expect individual languages to override this check?
Co-authored-by: Wes Haggard <[email protected]>
Co-authored-by: Wes Haggard <[email protected]>
weshaggard
approved these changes
Mar 29, 2024
|
The following pipelines have been queued for testing: |
praveenkuttappan
pushed a commit
to Azure/azure-sdk-for-js
that referenced
this pull request
Mar 29, 2024
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#7977
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Package name approval check is enforced for management plane package also due to a recent bug that got introduced as part of recent script restructure to consolidate language specific script into common script.
This PR has changes to skip package name check for management plane libraries.