Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[.NET] Add "Azure.Developer" to allowed namespace prefixes #7554

Merged
merged 2 commits into from
Jan 22, 2024

Conversation

joseharriaga
Copy link
Member

@joseharriaga joseharriaga commented Jan 19, 2024

The namespace prefix Azure.Developer.* was added to registered_namespaces.md as part of this Pull Request #7074 in the Azure/azure-sdk repo for services like Dev Center (Azure.Developer.DevCenter).

In this PR, we add the namespace prefix to the list of approved prefixes for the .NET analyzers. The Azure.Developer.DevCenter library is planning to GA with this Pull Request #40166 in the Azure/azure-sdk-for-net repo.

@pallavit
Copy link

pallavit commented Jan 22, 2024

Looking at the 'blessed list'

here seems short? Is this the full list we have? If not, do we usually go the route of disabling this warning since grep shows a lot of suppressions to this warning.

I guess I am curious - what is the recommended path here? Does the APIView have a check for package approval now? If so, does this warning simply becomes good to have? If not, should we also work towards cleaning up all the older supressions and make this list exhaustive?

@pallavit
Copy link

/cc: @JoshLove-msft , @christothes who may know more about this.

@christothes
Copy link
Member

In my experience, these warnings are only suppressed when a new one is introduced and is still in preview. The unsuppressed warning will break the build by default, since we treat warnings as errors.

@pallavit
Copy link

In my experience, these warnings are only suppressed when a new one is introduced and is still in preview. The unsuppressed warning will break the build by default, since we treat warnings as errors.

Ahh so this list then should be exhaustive for an SDK that is going GA? In that case, I do not have any concerns with the change.

@joseharriaga joseharriaga merged commit 7226bac into Azure:main Jan 22, 2024
17 checks passed
joseharriaga added a commit to Azure/azure-sdk-for-net that referenced this pull request Jan 22, 2024
The updated version of Azure.ClientSdk.Analyzers includes "Azure.Developer" as an approved namespace prefix, which means that we can now remove the suppression of AZC0001 from Azure.Developer.DevCenter.

More info here: Azure/azure-sdk-tools#7554
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants