Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make helper function "Install-ModuleIfNotInstalled" threadsafe #6521

Merged
merged 4 commits into from
Jul 15, 2023
Merged

Make helper function "Install-ModuleIfNotInstalled" threadsafe #6521

merged 4 commits into from
Jul 15, 2023

Conversation

mikeharder
Copy link
Member

@mikeharder mikeharder commented Jul 14, 2023 •
edited
Loading

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@mikeharder mikeharder marked this pull request as ready for review July 14, 2023 22:01
@mikeharder mikeharder requested review from benbp and a team as code owners July 14, 2023 22:01
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

This was referenced Jul 14, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
azure-sdk added a commit to Azure/azure-sdk-for-js that referenced this pull request Jul 15, 2023
@azure-sdk @mikeharder
Sync eng/common directory with azure-sdk-tools for PR 6521 (#26499)
ebe3443 
Sync eng/common directory with azure-sdk-tools for PR
Azure/azure-sdk-tools#6521 See [eng/common
workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow)

---------

Co-authored-by: Mike Harder <[email protected]>
@mikeharder mikeharder merged commit a3ce016 into Azure:main Jul 15, 2023
@mikeharder mikeharder deleted the install-module-threadsafe branch July 15, 2023 00:21
dgetu pushed a commit to Azure/azure-sdk-for-js that referenced this pull request Sep 6, 2023
@azure-sdk @mikeharder @dgetu
Sync eng/common directory with azure-sdk-tools for PR 6521 (#26499)
f949238 
Sync eng/common directory with azure-sdk-tools for PR
Azure/azure-sdk-tools#6521 See [eng/common
workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow)

---------

Co-authored-by: Mike Harder <[email protected]>
@benbp benbp mentioned this pull request Nov 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@konrad-jamrozik konrad-jamrozik konrad-jamrozik left review comments

@weshaggard weshaggard weshaggard approved these changes

@benbp benbp benbp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[eng/common] Helper function "Install-ModuleIfNotInstalled" is not threadsafe
5 participants
@mikeharder @azure-sdk @benbp @konrad-jamrozik @weshaggard