Support localspecrepo if pass in this parameter #6272
Conversation
raych1
requested review from
konrad-jamrozik,
weshaggard and
benbp
as code owners
|
The following pipelines have been queued for testing: |
| $gitRemotes = (git remote -v) | ||
| foreach ($remote in $gitRemotes) { | ||
| Write-Host "Checking remote $remote" | ||
| if ($remote.StartsWith("origin") -or $remote.StartsWith("main")) { |
There was a problem hiding this comment.
What context do we need to support "main" as a remote?
There was a problem hiding this comment.
These are the remotes in the pipeline run of test repo which doesn't have origin. That's why I added main.
10:29:05.890 cmdout [generate.py] Checking remote integration https://x-access-token:***@github.com/openapi-env-test/azure-sdk-for-java (fetch)
10:29:05.891 cmdout [generate.py] Checking remote integration https://x-access-token:***@github.com/openapi-env-test/azure-sdk-for-java (push)
10:29:05.891 cmdout [generate.py] Checking remote main https://x-access-token:***@github.com/openapi-env-test/azure-sdk-for-java (fetch)
10:29:05.891 cmdout [generate.py] Checking remote main https://x-access-token:***@github.com/openapi-env-test/azure-sdk-for-java (push)
10:29:05.891 cmdout [generate.py] Checking remote secondary https://x-access-token:***@github.com/openapi-env-test/azure-sdk-for-java (fetch)
10:29:05.892 cmdout [generate.py] Checking remote secondary https://x-access-token:***@github.com/openapi-env-test/azure-sdk-for-java (push)
There was a problem hiding this comment.
OK the automation pipeline must be doing something unique when it does its clones as by default origin is always set to what is cloned.
|
@raych1 can you please link the issue you are fixing with this in the description? |
|
The following pipelines have been queued for testing: |
|
@weshaggard , I took back my word. The change of adding an optional parameter to sync script isn't a breaking change and shouldn't break current usage. So, it's ok to merge this PR. |
Linked the issue in the first comment. |
|
The following pipelines have been queued for testing: |
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#6272 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) --------- Co-authored-by: raychen <[email protected]>
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#6272 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) --------- Co-authored-by: raychen <[email protected]>
LocalSpecRepoPathto sync script@weshaggard , this PR shouldn't be merged until all sdk language repos adopt new common scripts.
Fixing this issue in sync script.
#6279