Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete obsolete WebhookRouter tool #4966

Closed

Conversation

konrad-jamrozik
Copy link
Contributor

@konrad-jamrozik konrad-jamrozik commented Dec 14, 2022

This PR deletes obsolete WebhookRouter tool, per this comment: #4937 (review)

Once this PR is merged, I will also delete the internal / tools webhook-router pipeline.

@hallipr this PR requires your approval per the comment linked above.

Question to all reviewers: Should I reclaim anything from the deleted directory? E.g. the New-AzureDevOpsRuleCredentials.ps1 script?

@benbp
Copy link
Member

benbp commented Dec 14, 2022

I think it's ok to delete those scripts, even if they may contain some secret devops magic we may need to re-discover in the future.

Copy link
Member

@weshaggard weshaggard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I defer to @benbp and @hallipr on whether or not we need this any longer.

@konrad-jamrozik konrad-jamrozik self-assigned this Dec 15, 2022
@konrad-jamrozik konrad-jamrozik added the Central-EngSys This issue is owned by the Engineering System team. label Dec 15, 2022
@konrad-jamrozik
Copy link
Contributor Author

konrad-jamrozik commented Dec 17, 2022

@benbp @hallipr I ran in Application Insights this query, for last 7 days:

traces
| where message startswith "Sending event from route" or message startswith "Sent event from route"
| summarize count() by message

(sources for the messages here, in tools/webhook-router/Azure.Sdk.Tools.WebhookRouter/Routing/Router.cs)

and found this:

message count_
Sent event from route (cut) to namespace checkenforcerprod with hub name github-webhooks 15863
Sending event from route (cut) to namespace checkenforcerprod with hub name github-webhooks 15863
Sending event from route (cut) to namespace issuelabeler with hub name issue-labeler 1602
Sending event from route (cut) to namespace githubwebhooks with hub name githubwebhooks 2934
Sent event from route (cut) to namespace githubwebhooks with hub name githubwebhooks 2934
Sent event from route (cut) to namespace issuelabeler with hub name issue-labeler 1602

which gives us a list of recipients that possibly do something with these webhook events.

I did find checkenforcerprod and issuelabeler Event Hubs Namespaces in Azure SDK Engineering System subscription and githubwebhooks in Azure SDK Developer Playground subscription.

I could dig deeper and try to figure out what happens with these events downstream. But I am curious if you have some additional insights based on this data.

@konrad-jamrozik
Copy link
Contributor Author

konrad-jamrozik commented Dec 18, 2022

Per discussion with @hallipr on Teams:

  • we should wind down the consumers of the routed messages before decommissioning the router itself
  • additional insight: checkenforcerstaging hasn't had any outgoing messages in the last 30 days, but checkenforcerprod has, per investigation above

@konrad-jamrozik
Copy link
Contributor Author

I am closing this PR for now, as there is more work to be done before we can decommission the tool. I captured our findings and work required here:

Once the prerequisite work is done, we can re-open this PR.

@konrad-jamrozik konrad-jamrozik deleted the users/kojamroz/iss_4888_remove_webhook_router branch January 5, 2023 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Central-EngSys This issue is owned by the Engineering System team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants