-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete obsolete WebhookRouter tool #4966
Delete obsolete WebhookRouter tool #4966
Conversation
bc23cbe
to
1051350
Compare
I think it's ok to delete those scripts, even if they may contain some secret devops magic we may need to re-discover in the future. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@benbp @hallipr I ran in Application Insights this query, for last 7 days:
(sources for the messages here, in tools/webhook-router/Azure.Sdk.Tools.WebhookRouter/Routing/Router.cs) and found this:
which gives us a list of recipients that possibly do something with these webhook events. I did find I could dig deeper and try to figure out what happens with these events downstream. But I am curious if you have some additional insights based on this data. |
Per discussion with @hallipr on Teams:
|
I am closing this PR for now, as there is more work to be done before we can decommission the tool. I captured our findings and work required here: Once the prerequisite work is done, we can re-open this PR. |
This PR deletes obsolete
WebhookRouter
tool, per this comment: #4937 (review)Once this PR is merged, I will also delete the internal / tools webhook-router pipeline.
@hallipr this PR requires your approval per the comment linked above.
Question to all reviewers: Should I reclaim anything from the deleted directory? E.g. the New-AzureDevOpsRuleCredentials.ps1 script?