Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the new audience field #4728

Merged
1 commit merged into from
Nov 17, 2022
Merged

Use the new audience field #4728

1 commit merged into from
Nov 17, 2022

Conversation

sima-zhu
Copy link
Contributor

@sima-zhu sima-zhu commented Nov 16, 2022

Use the new audience for service readme script.

For docs:

  1. We use the APIs in release pipeline through Metadata-Helpers.ps1. (Fixed in this PR)
  2. We use the API in docindex pipeline through Metadata-Helpers.ps1. (Fixed in this PR)

For notification:

  1. We use the APIs from NotificationCreator through the GitHubToAADConverter

For pipeline owner extractor:

  1. We use the APIs from pipeline-owners-extractor through the GitHubToAADConverter

Testing pipeline: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1993950&view=results

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

Copy link
Member

@weshaggard weshaggard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this to fix the current issue but can you please file an issue to use our .NET tool similar to what we did in get-codeowners.ps1 script.

@ghost
Copy link

ghost commented Nov 17, 2022

Hello @azure-sdk!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 4b5b7ba into Azure:main Nov 17, 2022
@sima-zhu sima-zhu deleted the fix_audience branch November 17, 2022 19:09
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants