Fixed bug of deleting more than expected. #3250
Conversation
|
The following pipelines have been queued for testing: |
|
The following pipelines have been queued for testing: |
Co-authored-by: Wes Haggard <[email protected]>
|
The following pipelines have been queued for testing: |
| continue | ||
| } | ||
|
|
||
| LogDebug "Branch [ $branchName ] in repo [ $RepoId ] has a last commit date [ $commitDate ] that is older than $LastCommitOlderThan. " |
There was a problem hiding this comment.
Nit: I generally use single quotes for special values in strings vs. brackets with spaces, as it will make your log statement shorter and easier to read without horizontal scrolling in some situations.
There was a problem hiding this comment.
It is asking the change for the entire file. I am going to have follow up of switching github api to gh. I can make the changes over there.
| if (!$commitDate -or ($commitDate -gt $LastCommitOlderThan)) { | ||
| LogDebug "No last commit date or the branch $branch last commit date [ $commitDate ] is newer than the date $LastCommitOlderThan. Skipping." | ||
| continue | ||
| } |
There was a problem hiding this comment.
I think if you broke this up into two separate if+log statements then the reader wouldn't have to guess from the log which condition was true.
|
The following pipelines have been queued for testing: |
|
Hello @azure-sdk! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit 
https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1535947&view=results