-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to exit gracefully when all files in the diff are excluded #1946
Conversation
The following pipelines have been queued for testing: |
… 'files' config list are excluded by the expressions in 'ignorePaths'
The following pipelines have been queued for testing: |
The following pipelines have been queued for testing: |
…cript, logic for testing should happen above that and exit appropriately if running tests
The following pipelines have been queued for testing: |
Hello @azure-sdk! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Some exercise of eng/common synchronization scenarios revealed an interesting set of behaviors in cspell configuration:
cspell lint ...
IF all of the files in the cspell config file'sfile
section are excluded byignorePaths
from the config file. That is, when ignoringeng/common/**/*
and all files in the PR are changes toeng/common
, cspell will exit with an error and show help text implying that a file must be specified on the command line.files
configuration value includes a file which exists, is not empty, and is not excluded byignorePaths
--config <file path>
with configurations in "known" locations (e.g..vscode/cspell.json
)This change:
.vscode/cspell.json.ignore
which will not be picked up by cspell.