-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Test-Proxy] eng/common templates #1909
Conversation
…ture/add-proxy-common
The following pipelines have been queued for testing: |
Lets start with only one under eng/common and I'd suggest having a script that can be used to setup the certificate even if it is a separate command from the docker run. We can then wait for feedback about what people end up doing and make adjustments as necessary. My hope is that most folks doing this locally won't need to care about the certificate at all. |
@scbedd one possible solution: you could publish another docker image from tools that just contains the dev cert and the desired path, and then use multiple |
The following pipelines have been queued for testing: |
@benbp I am going to head this direction. First thing I'm going to do is force the build of the current dockerfile images from the root of the repo, thereby allowing access to the common assets. After that, I'll add two docker images that abstract the build of those assets. I would do it now, but I need to get this merged quickly. |
…icate. only necessary to add pre-step to container publish
The following pipelines have been queued for testing: |
The following pipelines have been queued for testing: |
The following pipelines have been queued for testing: |
eng/common/pipelines/templates/steps/install-pipeline-generation.yml
Outdated
Show resolved
Hide resolved
The following pipelines have been queued for testing: |
Hello @azure-sdk! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Changes in this PR:
Ok. @weshaggard I have added a
prepare.ps1
to thetest-proxy/docker
folder. Updated the documentation that refers to the certificate by name/location. Updated the docker build to be able to run theprepare.ps1
script.Successful Test invocation using these location changes in sdk-for-python
Successful Test container publish