Check for API review status only if release date is set in changelog #1729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
praveenkuttappan
added
Central-EngSys
|
The following pipelines have been queued for testing: |
This was referenced Jun 23, 2021
weshaggard
reviewed
Jun 23, 2021
weshaggard
reviewed
Jun 23, 2021
weshaggard
approved these changes
Jun 23, 2021
|
The following pipelines have been queued for testing: |
|
Hello @azure-sdk! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API review status is checked if package version is GA and this is causing issue for JA and Python packages which moves to new GA version after GA release. Any granular change in APIView forces architects to approve it even if release is weeks away to avoid build break and this requires additional effort from approvers. This change is to validate API review status only if version is GA and release date is present in change log. So developer can set the release date(not required to be exact date) whenever they are are ready to get API review reviewed.