Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable the link check for link verification step. #1019

Merged
1 commit merged into from
Oct 19, 2020

Conversation

sima-zhu
Copy link
Contributor

@sima-zhu sima-zhu commented Sep 17, 2020

This is the final step of link verification epic.

Enable the link guidance check for all Ci pipelines.

The PR is pending for all lang PRs:
java: Azure/azure-sdk-for-java#15285
net: Azure/azure-sdk-for-net#15223
python: Azure/azure-sdk-for-python#13846
js: Azure/azure-sdk-for-js#11317
ios: Azure/azure-sdk-for-ios#433
android: Azure/azure-sdk-for-android#348
go: Azure/azure-sdk-for-go#12541
cpp: Azure/azure-sdk-for-cpp#632
c: Azure/azure-sdk-for-c#1296

Copy link
Member

@weshaggard weshaggard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to do this eventually but lets hold until all the individual languages are clean.

@sima-zhu sima-zhu requested a review from weshaggard September 21, 2020 18:29
@sima-zhu sima-zhu closed this Oct 19, 2020
@sima-zhu sima-zhu deleted the enable_link_check branch October 19, 2020 16:03
@sima-zhu sima-zhu restored the enable_link_check branch October 19, 2020 16:03
@sima-zhu sima-zhu reopened this Oct 19, 2020
@sima-zhu
Copy link
Contributor Author

/azp run azure-sdk-tools - sync - eng-common

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
js - template
net - template
python - template
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@ghost
Copy link

ghost commented Oct 19, 2020

Hello @azure-sdk!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 370df1b into Azure:master Oct 19, 2020
@sima-zhu sima-zhu deleted the enable_link_check branch October 19, 2020 18:31
benbp pushed a commit that referenced this pull request Dec 1, 2020
sima-zhu pushed a commit to sima-zhu/azure-sdk-tools that referenced this pull request Dec 3, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants