Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the test flag from get-codeowners.ps1 to the common PS1 test infra, common-tests #5434

Closed
konrad-jamrozik opened this issue Feb 13, 2023 · 0 comments
Closed

Move the test flag from get-codeowners.ps1 to the common PS1 test infra, common-tests #5434

konrad-jamrozik opened this issue Feb 13, 2023 · 0 comments
Assignees
@konrad-jamrozik
Labels
Central-EngSys This issue is owned by the Engineering System team.

Comments

@konrad-jamrozik
Copy link
Contributor

konrad-jamrozik commented Feb 13, 2023 •
edited
Loading

Per this comment:

Related work:
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Feb 13, 2023
@konrad-jamrozik konrad-jamrozik self-assigned this Feb 13, 2023
@konrad-jamrozik konrad-jamrozik added the Central-EngSys This issue is owned by the Engineering System team. label Feb 13, 2023
@konrad-jamrozik konrad-jamrozik changed the title Move the test flag from get-codeowners to the common PS1 test infra Move the test flag from get-codeowners to the common PS1 test infra, common-tests Feb 13, 2023
@konrad-jamrozik konrad-jamrozik mentioned this issue Feb 13, 2023
Merged
@konrad-jamrozik konrad-jamrozik changed the title Move the test flag from get-codeowners to the common PS1 test infra, common-tests Move the test flag from get-codeowners.ps1 to the common PS1 test infra, common-tests Feb 13, 2023
@konrad-jamrozik konrad-jamrozik removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Feb 13, 2023
@konrad-jamrozik konrad-jamrozik mentioned this issue Mar 2, 2023
Merged
ghost pushed a commit that referenced this issue Mar 31, 2023
Move get-codeowners.ps1 test mode to common-tests + related impro…
b5cb2ed 
…vements & cleanup (#5608)

This PR moves the `Test` flag away from `get-codeowners.ps1` to the established `eng/common-tests` infrastructure, using PowerShell Pester testing framework. As such, it solves:

- #5434

This PR also:
- adds a README for the `eng/common-tests`;
- extracts the `get-codeowners.lib.ps1`, so that the functions can be reused between normal `get-codewners.ps1` usage and through Pester unit test invocations coming from `get-codeowners.tests.ps1`;
- changes some paths for related scripts and test scripts;
- moves some default params to `get-codeowners.lib.ps1` and hides some unused params; this was necessary to avoid default param value duplication between calls from `get-codeowners.ps1` and from `get-codeowners.tests.ps1`;
- applies some refactorings.

Associated changes made manually once this PR got merged:

- deleted internal pipeline [tools - eng-common-tests](https://dev.azure.com/azure-sdk/internal/_build/results?buildId=2605155&view=results); instead, created the public equivalent: [tools - eng-common-tests - ci](https://dev.azure.com/azure-sdk/public/_build?definitionId=5985).
  - For context, see [this comment](#5608 (comment)).

Follow-up work:
- #5878
@konrad-jamrozik konrad-jamrozik mentioned this issue Apr 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@konrad-jamrozik konrad-jamrozik

Labels
Central-EngSys This issue is owned by the Engineering System team.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@konrad-jamrozik