Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented Queue Peek Messages #92

Merged
merged 1 commit into from
Nov 23, 2020
Merged

Implemented Queue Peek Messages #92

merged 1 commit into from
Nov 23, 2020

Conversation

Alexei-B
Copy link

PR to implement #18
Fixed Get and Peek Messages on Empty Queue

@Alexei-B
Copy link
Author

Prior to the change to get messages to handle empty queues, an empty queue produces this response from the get_messages example:
image

After this change, you get this result:
image

MindFlavor
MindFlavor approved these changes Nov 23, 2020
View reviewed changes
Copy link
Contributor

@MindFlavor MindFlavor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, thank you!

You just need to fix the conflicts and we will merge this.

Implemented Queue Peek Messages
ad84c56 
Fixed Get and Peek Messages on Empty Queue
@Alexei-B
Copy link
Author

Rebased from upstream to fix merge conflicts.

@MindFlavor MindFlavor merged commit 63270df into Azure:master Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MindFlavor MindFlavor MindFlavor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Alexei-B @MindFlavor