Move find_blobs_by_tags to pipeline
#826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmc-msft
reviewed
Jun 17, 2022
| timeout: Timeout => Some(timeout), | ||
| } | ||
|
|
||
| // TODO: Make this a stream instead of a `Future` |
There was a problem hiding this comment.
There are a handful of places we're not paging. It's probably worth opening work items for these.
bmc-msft
approved these changes
Jun 17, 2022
cataggar
changed the title
find_blobs_by_tag to pipelinefind_blobs_by_tags to pipeline
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of #811. The
storagecrate is now fully on the pipeline. Unfortunately, we still have to keep around the code from the old architecture until the other storage crates make the transition.