Typo in KeyVaultClient causes invalid authorization request #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Azure("AuthorizationError(Failed to authenticate to Azure Active Directory
Caused by:
Generic error: AADSTS70011: The provided request must include a \'scope\' input parameter. The provided value for the input parameter \'scope\' is not valid.
The scope https://vault.azure.net.default is not valid
rylev
approved these changes
Nov 9, 2020
sdk/key_vault/src/client.rs
Outdated
| @@ -75,7 +75,7 @@ impl<'a, T: TokenCredential> KeyVaultClient<'a, T> { | |||
| // Token is valid, return it. | |||
| return Ok(()); | |||
| } | |||
| let resource = format!("https://{}", &self.endpoint_suffix); | |||
| let resource = format!("https://{}/", &self.endpoint_suffix); | |||
There was a problem hiding this comment.
I wonder if we should check the endpoint_suffix for an existing beginning / and only add an / if one is not already present.
There was a problem hiding this comment.
That's a good point. I guess a nice way might be to make get_token accept Url but I don't know enough about OAUTH2 or this sdk to know if that makes sense.
As a short stop I've done as you've suggested 👍
MindFlavor
approved these changes
Nov 10, 2020
|
@MindFlavor , Is there anything else I need to do to get this change merged in? |
|
Sorry @jefshe, it's my fault, I have missed rylev's approval. |
|
No worries! Thanks for merging it in! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got this error while trying out the
KeyVaultClientadding a forward slash fixes the crash