Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[datalake] Remove Box::pin where Pageable is returned #680

Merged
merged 1 commit into from
Mar 9, 2022
Merged

[datalake] Remove Box::pin where Pageable is returned #680

merged 1 commit into from
Mar 9, 2022

Conversation

roeap
Copy link
Contributor

@roeap roeap commented Mar 9, 2022

After #668 we no longer need to wrap the return of into_stream in Box::pin. This PR removes all such occurrences from the datalake crate.

@thovoll @yoshuawuyts

yoshuawuyts
yoshuawuyts approved these changes Mar 9, 2022
View reviewed changes
Copy link
Contributor

@yoshuawuyts yoshuawuyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; thank you!

@yoshuawuyts yoshuawuyts merged commit 027f111 into Azure:main Mar 9, 2022
@roeap roeap deleted the rm-box-pin branch March 9, 2022 10:14
rylev
rylev approved these changes Mar 9, 2022
View reviewed changes
Copy link
Contributor

@rylev rylev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoshuawuyts yoshuawuyts yoshuawuyts approved these changes

@rylev rylev rylev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@roeap @rylev @yoshuawuyts