replace unwrap calls in azure_core
#661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In multiple places, the SDK panics at runtime. This changes the unwrap calls to handle the error in a non-panic fashion. For places that have predicates that validate the invariant, unwrap has been replaced with `expect` that describes the justification. This is related to, but does not address, Azure#652
rylev
suggested changes
Feb 22, 2022
rylev
approved these changes
Feb 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In multiple places, the SDK panics at runtime. This changes the unwrap
calls to handle the error in a non-panic fashion.
For places that have predicates that validate the invariant, unwrap has
been replaced with
expectthat describes the justification.This is related to, but does not address, #652