handling a crate::Error example #612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rylev
approved these changes
Jan 24, 2022
There was a problem hiding this comment.
This looks good and still fits with the proposal for errors that @yoshuawuyts and I have been working on.
| } | ||
| } | ||
|
|
||
| fn print_error_chain(error: impl std::error::Error) { |
There was a problem hiding this comment.
We may want to add that there is ecosystem support for this. For example eyre
There was a problem hiding this comment.
I added the eyre example code and a note.
cataggar
requested review from
briancr-ms and
bmc-msft
and removed request for
briancr-ms
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current
crate::Errordesign is still lacking documentation, so here is what I think a common use case will be. The user wants to do structured errors, but does not care about the specific error type in azure_svc_batch. This case can be handled by implementingFromforInto<azure_svc_batch::Error>.One design caveat is that all structured errors must have a
Fromdefined in thecrate::Errorand it should not defineFromimplementations for errors that are not in crate.For printing of source errors, it is important that source be defined. #611 updated core & I'll need to update the services.