-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update to latest service specs #562
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one question, but nothing blocking. Since this is generated code, I sampled various files, being sure to check out a few of each file name e.g., Cargo.toml, lib.rs, mod.rs, operations.rs, and odels.rs. I think that covered them all.
@@ -0,0 +1,4 @@ | |||
pub mod models; | |||
pub mod operations; | |||
#[allow(dead_code)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we generate packages per api-version, is this even useful i.e. for the user to be able to specify the api-version (as a string or constant)? Seems redundant given the intended use case with crate features.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I opened up #563 to review API versioning.
Thanks for the review @heaths. I also run the --all-features test before merging large updates. Looks like I need to fix:
https://github.com/ctaggart/azure-sdk-for-rust/runs/4703057191?check_suite_focus=true |
Each batch of updates brings in a few properties that need updating. With the latest updates to resolve everything before codegen, automatically finding these may be possible. #225
|
https://github.com/ctaggart/azure-sdk-for-rust/runs/4725927764?check_suite_focus=true |
Azure/azure-rest-api-specs@322d0ed