Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to latest service specs #562

Merged
merged 7 commits into from
Jan 6, 2022
Merged

Conversation

ctaggart
Copy link
Contributor

@ctaggart ctaggart commented Jan 4, 2022

Copy link
Member

@heaths heaths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question, but nothing blocking. Since this is generated code, I sampled various files, being sure to check out a few of each file name e.g., Cargo.toml, lib.rs, mod.rs, operations.rs, and odels.rs. I think that covered them all.

@@ -0,0 +1,4 @@
pub mod models;
pub mod operations;
#[allow(dead_code)]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we generate packages per api-version, is this even useful i.e. for the user to be able to specify the api-version (as a string or constant)? Seems redundant given the intended use case with crate features.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I opened up #563 to review API versioning.

@cataggar
Copy link
Member

cataggar commented Jan 5, 2022

Thanks for the review @heaths. I also run the --all-features test before merging large updates. Looks like I need to fix:

    Checking azure_svc_mixedreality v0.1.0 (/Users/runner/work/azure-sdk-for-rust/azure-sdk-for-rust/services/svc/mixedreality)
error[E0072]: recursive type `InnerError` has infinite size
  --> svc/mixedreality/src/package_0_3_preview_0/models.rs:94:1
   |
94 | pub struct InnerError {
   | ^^^^^^^^^^^^^^^^^^^^^ recursive type has infinite size
...
98 |     pub innererror: Option<InnerError>,
   |                     ------------------ recursive without indirection
   |
help: insert some indirection (e.g., a `Box`, `Rc`, or `&`) to make `InnerError` representable
   |
98 |     pub innererror: Box<Option<InnerError>>,
   |                     ++++                  +

https://github.com/ctaggart/azure-sdk-for-rust/runs/4703057191?check_suite_focus=true

@cataggar
Copy link
Member

cataggar commented Jan 5, 2022

Each batch of updates brings in a few properties that need updating. With the latest updates to resolve everything before codegen, automatically finding these may be possible. #225

error[E0072]: recursive type `package_2021_12_preview::models::InnerError` has infinite size
   --> mgmt/dataprotection/src/package_2021_12_preview/models.rs:761:1
    |
761 | pub struct InnerError {
    | ^^^^^^^^^^^^^^^^^^^^^ recursive type has infinite size
...
767 |     pub embedded_inner_error: Option<InnerError>,
    |                               ------------------ recursive without indirection
    |
help: insert some indirection (e.g., a `Box`, `Rc`, or `&`) to make `package_2021_12_preview::models::InnerError` representable
    |
767 |     pub embedded_inner_error: Box<Option<InnerError>>,
    |                               ++++                  +
    ```

@cataggar
Copy link
Member

cataggar commented Jan 6, 2022

error[E0072]: recursive type `package_2021_06_30_preview::models::InnerError` has infinite size
  --> svc/digitaltwins/src/package_2021_06_30_preview/models.rs:69:1
   |
69 | pub struct InnerError {
   | ^^^^^^^^^^^^^^^^^^^^^ recursive type has infinite size
...
73 |     pub innererror: Option<InnerError>,
   |                     ------------------ recursive without indirection
   |
help: insert some indirection (e.g., a `Box`, `Rc`, or `&`) to make `package_2021_06_30_preview::models::InnerError` representable
   |
73 |     pub innererror: Box<Option<InnerError>>,
   |                     ++++                  +

https://github.com/ctaggart/azure-sdk-for-rust/runs/4725927764?check_suite_focus=true

@cataggar cataggar merged commit a65cf49 into Azure:main Jan 6, 2022
@ctaggart ctaggart deleted the latest_specs branch January 25, 2022 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants