Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor mock support #540

Merged
merged 7 commits into from
Dec 13, 2021
Merged

Refactor mock support #540

merged 7 commits into from
Dec 13, 2021

Conversation

rylev
Copy link
Contributor

@rylev rylev commented Dec 13, 2021

This moves everything mock transport framework related under a mock module which only exposes the things used publicly (some constants).

@rylev rylev requested a review from yoshuawuyts December 13, 2021 10:41
yoshuawuyts
yoshuawuyts approved these changes Dec 13, 2021
View reviewed changes
Copy link
Contributor

@yoshuawuyts yoshuawuyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this a lot. It doesn't feel like much has changed in terms of functionality; it's all just a little bit tidier. Thanks!

@rylev rylev merged commit 636fb4a into Azure:main Dec 13, 2021
@rylev rylev deleted the refactor-mock-support branch December 13, 2021 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoshuawuyts yoshuawuyts yoshuawuyts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rylev @yoshuawuyts