Squash warnings on main #535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should gradually revert this PR and remove every single `#[allow(unused)]` call inserted. We did it this way in order to un-break the main branch. Co-Authored-By: Ryan Levick <[email protected]>
Co-Authored-By: Ryan Levick <[email protected]>
Co-Authored-By: Ryan Levick <[email protected]>
Co-Authored-By: Ryan Levick <[email protected]>
Co-Authored-By: Ryan Levick <[email protected]>
Co-Authored-By: Ryan Levick <[email protected]>
Co-Authored-By: Ryan Levick <[email protected]>
Co-Authored-By: Ryan Levick <[email protected]>
Co-Authored-By: Ryan Levick <[email protected]>
Co-Authored-By: Ryan Levick <[email protected]>
Co-Authored-By: Ryan Levick <[email protected]>
Merged
ctaggart
reviewed
Jan 1, 2022
| @@ -4,7 +4,7 @@ on: | |||
| workflow_dispatch: | |||
|
|
|||
| env: | |||
| RUSTFLAGS: --deny warnings --allow unused_attributes --allow unreachable-code --allow unused-assignments | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main branch was seeing a lot of warnings, including clippy failures. This fixes those failures. Some of them are temporary, demarked by
#[allow(unused)]. We should remove those attributes in follow-up PRs. Thanks!