Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crate::Error for services #497

Merged
merged 10 commits into from
Nov 8, 2021
Merged

Conversation

ctaggart
Copy link
Contributor

@ctaggart ctaggart commented Nov 7, 2021

Fixes #393. This adds a crate::Error to each generated services crate. It is a reexported operations::Error.

I made a bit of progress on separating out openapi and codegen in AutoRust:

  • added fn spec.operations()
  • get_type_name_for_schema & get_type_name_for_schema_ref now return a TypeName

The generated operations now quality models:: to avoid conflicts with the new Error type. The azure-rest-api-specs are updated to commit fdf486a42c7d86dd00802414a5811d5b63c5e917.

@cataggar cataggar requested a review from bmc-msft November 7, 2021 19:35
@ctaggart
Copy link
Contributor Author

ctaggart commented Nov 8, 2021

I'll have another PR ready with changes from ctaggart#4 to fix more data plane crates after this gets merged.

@cataggar cataggar merged commit e6b2138 into Azure:main Nov 8, 2021
@ctaggart ctaggart deleted the services_crate_error branch December 31, 2021 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

crate::Error for services
3 participants