Finish Cosmos database client #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cataggar
approved these changes
Oct 28, 2021
| use azure_core::collect_pinned_stream; | ||
| use azure_core::headers::{continuation_token_from_headers_optional, session_token_from_headers}; | ||
| use azure_core::prelude::*; | ||
| use azure_core::Request as HttpRequest; |
There was a problem hiding this comment.
Should we rename them to HttpRequest in Core (in another PR?
There was a problem hiding this comment.
Sounds good. I made an issue for this: #462
MindFlavor
approved these changes
Oct 28, 2021
| ) -> crate::Result<DeleteDatabaseResponse> { | ||
| let mut request = self | ||
| .cosmos_client() | ||
| .prepare_request_pipeline(&format!("dbs/{}", self.database_name()), http::Method::GET); |
There was a problem hiding this comment.
We should probably escape the resources (in this case the db name) at some point. To conform with other SDKs we should not validate the name (we decided to leave it to Azure) but improperly escaped URIs can cause trouble and can have security implications.
I've created #459 to track this.
rylev
force-pushed
the
finish-db-client
branch
from
649962b to
20c8f14
Compare
dimbleby
reviewed
Oct 30, 2021
| ) -> crate::Result<DeleteDatabaseResponse> { | ||
| let mut request = self | ||
| .cosmos_client() | ||
| .prepare_request_pipeline(&format!("dbs/{}", self.database_name()), http::Method::GET); |
There was a problem hiding this comment.
This GETs the database, it doesn't delete it at all!
Will be fixed in #375 once we catch up with main and update that MR, if you don't get to it first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the remaining operations in the Comsos database client over to the pipeline architecture.
It also expands a test to exercise listing collections and deleting a database. Happily, this prevented a bug from being checked in. 😊