Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use Url instead of String for Blob URLs #422

Merged
merged 3 commits into from
Oct 20, 2021
Merged

use Url instead of String for Blob URLs #422

merged 3 commits into from
Oct 20, 2021

Conversation

bmc-msft
Copy link
Contributor

As a user, I expect generate_*_url to return a Url, not a String.

@bmc-msft bmc-msft changed the title change generate_signed_blob_url to return Url instead of String use Url instead of String for Blob URLs Oct 20, 2021
rylev
rylev approved these changes Oct 20, 2021
View reviewed changes
Copy link
Contributor

@rylev rylev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@bmc-msft bmc-msft merged commit 2f1ca2e into Azure:main Oct 20, 2021
@bmc-msft bmc-msft deleted the generate_signed_blob_url-should-be-url branch October 20, 2021 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rylev rylev rylev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bmc-msft @rylev