Pass authorization token to cosmos client in mock_transport_framework test #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rylev
suggested changes
Oct 11, 2021
Comment on lines
+19
to
+22
| let key = | ||
| std::env::var("COSMOS_MASTER_KEY").expect("Set env variable COSMOS_MASTER_KEY first!"); | ||
|
|
||
| AuthorizationToken::primary_from_base64(&key) |
There was a problem hiding this comment.
We also don't want to require that the auth key is set when running the tests on replay mode. Similar to how we're first checking for the TESTING_MODE_KEY before getting the account name, we should do the same for the authorization token.
There was a problem hiding this comment.
Have tried to do something similar. Handling the Result type was a bit more fiddly but let me know if there is a better way to do it.
rylev
reviewed
Oct 12, 2021
| @@ -24,8 +30,15 @@ pub fn initialize( | |||
| == Ok(azure_core::TESTING_MODE_RECORD)) | |||
| .then(get_account) | |||
| .unwrap_or_else(String::new); | |||
| let authorization_token = (std::env::var(azure_core::TESTING_MODE_KEY).as_deref() | |||
| == Ok(azure_core::TESTING_MODE_RECORD)) | |||
| .then(|| get_authorization_token().ok()) | |||
There was a problem hiding this comment.
Might be better for us to just unwrap the error. If the testing mode is set to record but we can't parse the auth token, that's a bug.
rylev
approved these changes
Oct 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.