Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cosmos] Migrate (get, replace, delete)_collection to pipeline architecture #373

Merged
merged 3 commits into from
Oct 14, 2021
Merged

[Cosmos] Migrate (get, replace, delete)_collection to pipeline architecture #373

merged 3 commits into from
Oct 14, 2021

Conversation

JoshGendein
Copy link
Member

Moving get_collection, replace_collection, and delete_collection to pipeline architecture.

Continuing #290

rylev
rylev approved these changes Oct 4, 2021
View reviewed changes
Copy link
Contributor

@rylev rylev left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I'm going to merge this, but we should make an effort to start using the mock transport framework to add tests for these.

This also needs to be rebased.

@JoshGendein
Copy link
Member Author

@rylev I added a new test called collection_operations, I couldn't port the existing test cosmos_collection because it uses list_collections which isn't migrated to pipeline architecture yet.

@rylev rylev merged commit b7b53f7 into Azure:main Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rylev rylev rylev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoshGendein @rylev