Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove en-us from links #313

Merged
merged 1 commit into from
Jun 22, 2021
Merged

remove en-us from links #313

merged 1 commit into from
Jun 22, 2021

Conversation

ctaggart
Copy link
Contributor

Though just a source comment, Azure SDKs asks that URLs not be pre-localized so that a browser's preferred locales are used.
https://github.com/Azure/azure-sdk-for-rust/pull/312/files#r655608833

@ctaggart ctaggart requested a review from heaths June 22, 2021 00:59
@ctaggart ctaggart mentioned this pull request Jun 22, 2021
Merged
heaths
heaths approved these changes Jun 22, 2021
View reviewed changes
Copy link
Member

@heaths heaths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding them all! We have some docs scripts that we run in other repos we could eventually hook up, which also check for other docs issues.

rylev
rylev approved these changes Jun 22, 2021
View reviewed changes
Copy link
Contributor

@rylev rylev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rylev rylev merged commit c9d1fa1 into Azure:master Jun 22, 2021
@ctaggart ctaggart deleted the locale branch September 1, 2021 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heaths heaths heaths approved these changes

@rylev rylev rylev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ctaggart @rylev @heaths