Fix BOM handling in queue responses #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heaths
reviewed
Jun 18, 2021
There was a problem hiding this comment.
Rather than stripping/skipping the BOM from all responses like this, what about just ignoring the BOM in the response itself? JSON is supposed to be UTF-8, and any different encoding should be reflected in the Content-Encoding header. Doing this centrally would be more productive than having to strip/skip it everywhere it's used.
ctaggart
suggested changes
Jun 20, 2021
There was a problem hiding this comment.
There is no need to convert to a str to strip a UTF-8 BOM. serde_xml_rs can read directly from a byte slice. I created a slice_bom & read_xml functions in impero-com#2 to add to this.
|
Thanks, that is entirely right. |
ctaggart
approved these changes
Jun 21, 2021
heaths
approved these changes
Jun 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this PR fixes the BOM handling in queue API responses.