add new_http_client & fix cosmos_client #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctaggart
changed the title
ctaggart
commented
May 31, 2021
| use azure_core::*; | ||
|
|
||
| #[derive(Clone, Debug)] | ||
| enum TransportStack { |
There was a problem hiding this comment.
I don't understand why you would have an HttpClient or a Pipeline. May be it can this can be reintroduced in a subsequent pull request.
rylev
approved these changes
Jun 1, 2021
| @@ -51,52 +46,76 @@ impl CosmosOptions { | |||
| } | |||
| } | |||
|
|
|||
| /// Create a Pipeline from CosmosOptions | |||
| fn new_pipeline_from_options(options: CosmosOptions) -> Pipeline { | |||
There was a problem hiding this comment.
Nit: I personally like keeping the struct definition and the impl together which would mean moving these functions below the impl block. That's definitely not a blocker though.
There was a problem hiding this comment.
I'm fine with either. I'll change it to be in the impl. Let's change it to a impl when the pipeline stuff gets refactored.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix cosmos create_database unable to get pipeline in cosmos e2e tests #273. From Policy Architecture #204, I don't really understand what
TransportStackis for. This removes it.new_http_client()to simplify creation, reduceuse statementsand simplify dependenciesBoxin theArc<Box. It seems to work fine without. Did I miss something?