Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for queries #240

Merged
merged 5 commits into from
Jun 4, 2021

Conversation

corollaries
Copy link
Contributor

This PR adds support for queries to the IoT Hub SDK.

The REST API for queries uses the x-ms-item-count header which was already used in the cosmos crate. Therefore I decided to move this from cosmos to core so I'd be able to use it in iothub as well.

Also added a couple of log statements that should help with debugging.

Copy link
Contributor

@rylev rylev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the long delay! This looks good. Thank you! I just had one comment that I'd like to address before merging.

sdk/iothub/src/service/responses/device_twin_response.rs Outdated Show resolved Hide resolved
@corollaries corollaries force-pushed the feature/corollaries/support-queries branch from ed70dfc to a07f5e6 Compare June 3, 2021 15:40
Copy link
Contributor

@rylev rylev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@rylev rylev merged commit 3f99267 into Azure:master Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants