Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed builders from AMQP #1906

Merged
merged 3 commits into from
Nov 8, 2024

Conversation

LarryOsterman
Copy link
Member

Removed Options builders from AMQP library.

Kept builders for more complicated types (AmqpSource, AmqpTarget, AmqpMessageHeader, AmqpMessageProperties, and AmqpMessage`).

AmqpMessageHeader and AmqpMessageProperties may be candidates for removing the builder as well, that will be revisited in a later iteration.

Github Copilot Summary.

This pull request involves significant changes to the sdk/core/azure_core_amqp module, primarily focusing on simplifying the configuration options and removing the builder pattern. The primary changes include making the fields of the options structs public and eliminating the builder structs and methods.

Simplification of Configuration Options:

Code Adjustments:

@heaths
Copy link
Member

heaths commented Nov 8, 2024

@microsoft-github-policy-service rerun

@LarryOsterman LarryOsterman merged commit 54db2ca into Azure:main Nov 8, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants