Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed Options builders from AMQP library.
Kept builders for more complicated types (
AmqpSource
,AmqpTarget
,AmqpMessageHeader
,AmqpMessageProperties
, and AmqpMessage`).AmqpMessageHeader
andAmqpMessageProperties
may be candidates for removing the builder as well, that will be revisited in a later iteration.Github Copilot Summary.
This pull request involves significant changes to the
sdk/core/azure_core_amqp
module, primarily focusing on simplifying the configuration options and removing the builder pattern. The primary changes include making the fields of the options structs public and eliminating the builder structs and methods.Simplification of Configuration Options:
sdk/core/azure_core_amqp/src/connection.rs
: Made fields inAmqpConnectionOptions
public and removed thebuilders::AmqpConnectionOptionsBuilder
struct and its methods. Updated tests to directly instantiateAmqpConnectionOptions
instead of using the builder. [1] [2] [3] [4] [5]sdk/core/azure_core_amqp/src/receiver.rs
: Made fields inAmqpReceiverOptions
public and removed thebuilders::AmqpReceiverOptionsBuilder
struct and its methods. Updated tests to directly instantiateAmqpReceiverOptions
instead of using the builder. [1] [2] [3] [4] [5] [6] [7]sdk/core/azure_core_amqp/src/sender.rs
: Made fields inAmqpSenderOptions
public and removed thebuilders::AmqpSenderOptionsBuilder
struct and its methods.Code Adjustments:
sdk/core/azure_core_amqp/src/fe2o3/receiver.rs
: Updated usage ofAmqpReceiverOptions
to reflect the removal of the builder pattern.