Update Rust's CODEOWNERS baseline files to remove a couple of invalid path entries #1873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JimSuplizio
added
the
Central-EngSys
JimSuplizio
requested review from
RickWinter,
ronniegeraghty and
a team
as code owners
I'd like to keep it that way. To direct issues we have to find owners anyway. No sense in kicking the problem down the road till they build up to a daunting task. |
heaths
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered these entries when I was generating the CODEOWNERS_baseline_errors.txt file for Rust in preparation for creating Rust's codeowners-linter pipeline. As it turns out, these were the only errors because their paths do not exist in the repository.
As per @heaths's guidance the entires for /sdk/template/ and /eng/pipelines/aggregate-reports.yml were removed.
As per @weshaggard's explanation, the /.config/1espt/ doesn't exist yet but will when we start auto-baselining functionality from the 1ES template. The entry should be recreated at that time.
@RickWinter - Congratulations! With the above errors being fixed in this PR, Rust does not yet need a baseline error file making it only repository that doesn't.