Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate re-export of Model macro #1864

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Conversation

heaths
Copy link
Member

@heaths heaths commented Oct 22, 2024

Also re-exports Model from azure_core along with some other types that were exported from the crate root in track 1.

Also re-exports `Model` from `azure_core` along with some other types that were exported from the crate root in track 1.
@heaths heaths merged commit 1038a6f into Azure:main Oct 22, 2024
26 checks passed
@heaths heaths deleted the model-derive-fix branch October 22, 2024 23:51
Copy link
Member

@RickWinter RickWinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice clean up, thanks for fixing

@heaths
Copy link
Member Author

heaths commented Oct 23, 2024

For posterity, this may clean up some incidental compile-time errors where the macro was imported from typespec_client_core::Model but everything else in typespec_client_core::http was out of scope.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants